Fix Email module Badge variants to match component API#82
Merged
antosubash merged 6 commits intomainfrom Apr 5, 2026
Merged
Conversation
The Badge component supports 'default', 'success', 'danger', 'warning',
and 'info' variants. The Email Dashboard and History pages were using
non-existent variants ('destructive', 'secondary', 'outline') causing
the badges to render without proper styling.
The project had tsconfig.json with strict mode but never ran tsc, allowing invalid component prop types to slip through (like the Email module's Badge variant bug). Changes: - Add tools/typecheck.mjs that runs tsc --noEmit per module - Add "typecheck" script to package.json check pipeline - Fix SharedProps missing index signature for Inertia PageProps - Fix Badge variant mismatches in RateLimiting and Email modules - Fix Button variant 'destructive' -> 'danger' in Users module - Fix number-to-string type mismatches across multiple modules - Fix string|undefined -> string assignments in Products/Tenants - Add CSS module declaration to PageBuilder tsconfig
Break the single `npm run check` into separate steps: biome lint, pages validation, i18n validation, and TypeScript type check. Each step fails fast independently, and since build/e2e depend on the lint job, type errors now block the entire pipeline.
- Run tsc checks in parallel via Promise.all instead of sequentially - Resolve tsc binary directly instead of spawning npx on each invocation - Move Record<string, unknown> from SharedProps interface to usePage<> call sites, preserving type safety on the exported interface - Replace magic depth parameter with descriptive 'flat'/'nested' layout
Deploying simplemodule-website with
|
| Latest commit: |
ecfe1f5
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2e596dca.simplemodule-website.pages.dev |
| Branch Preview URL: | https://claude-fix-email-module-page.simplemodule-website.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Badge component supports 'default', 'success', 'danger', 'warning',
and 'info' variants. The Email Dashboard and History pages were using
non-existent variants ('destructive', 'secondary', 'outline') causing
the badges to render without proper styling.